-
Notifications
You must be signed in to change notification settings - Fork 945
allow numpy 2.3 #1142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.x
Are you sure you want to change the base?
allow numpy 2.3 #1142
Conversation
setup.py
Outdated
install_requires = [ | ||
'numpy<2.0; python_version<"3.9"', | ||
'numpy(>=2, <2.3.0); python_version>="3.9"', | ||
'numpy(>=2, <2.4.0); python_version>="3.9"', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- just
numpy>=2
- drop comment above this section
We should not push unnecessary locks on user environment.
@asmorkalov CI environment should be pinned instead (if necessary - probably not).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Updated to >2
in 7bd1825
fbcf29e
to
95f2778
Compare
95f2778
to
7bd1825
Compare
This would be good to have considering python 3.14 is around the corner and numpy 2.3.x adds support for that version. Currently, opencv users cannot test against python 3.14 (easily). I found this out today when trying to setup some 3.14 canary pipelines |
Just saw this was approved, hopefully this gets merged and included in a release soon so we can derisk python3.14 |
This PR relaxes the runtime numpy dependency to allow the latest released minor version (2.3.x).
This follows the recommendations linked in #1119 (which added the runtime upper pin) and updates the pin based on the latest released version.EDIT: see #1142 (comment) for discussion on pinissue #1140 #1135